Skip to content

Improve bisect script #16294

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 21, 2022
Merged

Improve bisect script #16294

merged 1 commit into from
Nov 21, 2022

Conversation

prolativ
Copy link
Contributor

@prolativ prolativ commented Nov 7, 2022

  • Support checking runtime success while bisecting
  • Properly report cases when no release was bad
  • Get correct results when running the script directly from the repository root

@prolativ prolativ changed the title Improve bisect script: Improve bisect script Nov 7, 2022
KacperFKorban
KacperFKorban approved these changes Nov 21, 2022
View reviewed changes
Copy link
Member

@KacperFKorban KacperFKorban left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@prolativ
Improve bisect script:
d2f4c12 
  * Support checking runtime success while bisecting
  * Properly report cases when no release was bad
  * Get correct results when running the script directly from the repository root
@KacperFKorban KacperFKorban merged commit 4af64cd into scala:main Nov 21, 2022
@KacperFKorban KacperFKorban deleted the bisect-run branch November 21, 2022 15:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@KacperFKorban KacperFKorban KacperFKorban approved these changes

Assignees

@prolativ prolativ

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@prolativ @KacperFKorban